-
Couldn't load subscription status.
- Fork 116
[oneDPL] Extend and improve the wording about parallel algorithms #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[oneDPL] Extend and improve the wording about parallel algorithms #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any additional comments beyond Dmitriy's feedback.
| that take a oneDPL execution policy. | ||
|
|
||
| For all parallel algorithms (including ones with ranges) oneDPL implements list-initialization, where applicable, | ||
| as described in `P2248R8`_ proposal that is accepted for C++26. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think that linking to the accepted proposal is overkill here beyond mentioning the C++26 working draft? It may be more accessible currently to list the proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow the pattern which we already use for the parallel range API.
I think referring to the working draft (without a link) is sufficient for the key message: the API follows the path taken by the standard. I suppose that somebody who needs the details can find those out in the working draft.
I can be convinced that referring to accepted proposals provides more value - especially if this feedback comes from the users of the API/specification :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit torn. Obviously pointing to the standard draft is a little difficult to navigate if you are looking for specifics. However, it is likely the best long term option for the specification.
The paper provides easier to access details when we are talking at such a high level here without much verbosity or example etc.
I don't have a strong feeling either way, but a slight preference to including the paper with link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you want to add the link for the paper, I can re-approve as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The patch is mostly editorial, but also extends the "Parallel Algorithms" page with some basic information about the C++17/20 standard-aligned parallel algorithms oneDPL provides.